465a235 Call component rewriter in pre 1.20.3 advancement handler (#4014)
Required for ViaBackwards where we need to rewrite the translation key (and it also doesn't hurt to have this in forward protocols).
Closes https://github.com/ViaVersion/ViaBackwards/issues/819
303d9ec Hide cooldown indicator completely in 1.8->1.9 (#4006)
-
Change 1.8 to 1.9 Attack Speed
-
Fix The Attack Speed Value Type
-
Change Attack Speed to 20
Requested/Suggested change from FlorianMichael
Co-authored-by: EnZaXD florian.michael07@gmail.com
Co-authored-by: EnZaXD florian.michael07@gmail.com
1735812 Fix: delay chat acknowledgements instead of spoofing (#3997)
An easy reproduction case is to mute a player using the Social Interactions screen, let them chat, and then send a message. As ViaVersion produces its own acknowledgements, this now does not match with what the client produced and signed its messages with - so the signature will fail verification.
As an alternative, we always pass through the same acknowledgement bit set - and for 'spoofed' messages, we reuse the last one that we received. In the case of the chat ack packet with just an offset, we need to hold back the window by at least 20 messages to ensure we don't start making claims about whether the client saw a message that ViaVersion cannot yet make a judgement on.